Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINE] Add ownership for MiqRequest in RBAC #17245

Merged
merged 1 commit into from
Apr 16, 2018
Merged

[FINE] Add ownership for MiqRequest in RBAC #17245

merged 1 commit into from
Apr 16, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Apr 3, 2018 •
edited
Loading

@gtanzillo @lpichler
Merge pull request ManageIQ#17208 from lpichler/restrict_miq_request_…
832be6c 
…by_users_group

Add ownership for MiqRequest in RBAC
@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2018

Checked commit lpichler@832be6c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

spec/lib/rbac/filterer_spec.rb

@lpichler
Copy link
Contributor Author

lpichler commented Apr 6, 2018

@miq-bot add_label blocker, fine/yes

@simaishi simaishi requested a review from gtanzillo April 10, 2018 01:57
@simaishi simaishi added bug and removed fine/yes labels Apr 16, 2018
@simaishi simaishi merged commit aea62b8 into ManageIQ:fine Apr 16, 2018
@simaishi simaishi added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 16, 2018
@simaishi simaishi mentioned this pull request Apr 16, 2018
Merged
@lpichler lpichler deleted the restrict_miq_request_by_users_group_fine branch April 16, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@simaishi simaishi

Labels
blocker bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpichler @miq-bot @gtanzillo @simaishi