Adding scan action with userid to container_image

[nimrodshn]

What this does?

Currently a ContainerImage scan that was scheduled is not associated with the current userid. This patch allows the user to schedule a ContainerImage scan associated with the current userid.

Why?

Currently scheduled ContainerImage scans are failing due to lack of associated userid required to create the Job.

cc: @cben @agrare @oourfali
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1559459

[nimrodshn]

@miq-bot add_label gaprindashvili/yes, bug

[lpichler]

does it make sense to encapsulate this If branch to the scan method ? ( and thanks to that have here only calling scan method )

[agrare]

What other objects is this called on? Can we just always pass the userid?

[nimrodshn]

@agrare EmsCluster also calls scan without userid, and without this if I would break their scan (to be honest I'm not acquainted with this entity at all.)

[cben]

To be honest we added the new method name and this if because we were unsure what other types other than ContainerImage support schedulable scan action, and hoped one of the reviewers could tell us ;-)
"the best way to get the right answer on the internet is not to ask a question; it's to post the wrong answer."

OK, let's see. scan methods and calls: https://gist.github.com/cben/c582b51e8eb14528fa4ed81243b43a85
Not sure if all these are smart state scans, and if all these are potential targets for MiqSchedule.
OK, indeed seems the only suspect except ContainerImage is EmsCluster:
https://github.com/ManageIQ/manageiq/blob/142129ed/app/models/ems_cluster.rb#L212-L220
Anybody knows what that is (and what's save_drift_state)?
Can/should we add an optional ignored userid arg to it?

[agrare]

Can/should we add an optional ignored userid arg to it?

Yeah I think so, all of the other scan methods are def scan(userid = "system", options = {}) so this would keep things consistent.

Anybody knows what that is (and what's save_drift_state)?

http://manageiq.org/docs/reference/fine/doc-Managing_Infrastructure_and_Inventory/miq/#detecting-drift-on-clusters
I'm not sure if this can be scheduled but it can be run from the UI.

"the best way to get the right answer on the internet is not to ask a question; it's to post the wrong answer."

LOL that is brilliant

[nimrodshn]

@agrare just to be sure were talking about scan in container_image.rb?

[agrare]

And EmsCluster#scan

[nimrodshn]

@agrare @cben fixed 👍 PTAL.

[miq-bot]

Checked commit nimrodshn@af34984 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

[cben]

Looks good.

[JPrause]

@miq-bot add_label blocker

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 84d84f380fa6924549c652132ebab353a4f10419
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Apr 10 12:14:30 2018 -0400

    Merge pull request #17264 from nimrodshn/add_scan_with_userid
    
    Adding scan action with userid to container_image
    (cherry picked from commit 959fcd687af3b4fa44ee3061c5c77fcd1926d529)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1566529