Add association of service_templates to TransformationMapping. #17266

lfu · 2018-04-09T18:27:47Z

A transformation mapping may be used by many service_template_transformation_plans.

@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, transformation

bzwei · 2018-04-09T19:55:04Z

app/models/transformation_mapping.rb

  def destination(source)
    transformation_mapping_items.find_by(:source => source).try(:destination)
  end
+
+  def service_template_transformation_plans


The actual logic does not filter for ServiceTemplateTransformationPlan although in reality they are likely always transformation plan. Should we relax the method name just service_templates?

bzwei · 2018-04-09T19:56:07Z

@lfu can you do an API test? Manual test is OK.

bzwei · 2018-04-10T13:15:23Z

app/models/transformation_mapping.rb

@@ -3,7 +3,13 @@ class TransformationMapping < ApplicationRecord

  validates :name, :presence => true, :uniqueness => true

+  virtual_has_many :service_template_transformation_plans


virtual_has_many :service_templates

lfu · 2018-04-10T13:35:17Z

@bzwei API test went well.

{
    "href": "http://localhost:3000/api/transformation_mappings/1",
    "id": "1",
    "name": "lucys testing",
    "description": null,
    "comments": null,
    "state": null,
    "options": {},
    "tenant_id": null,
    "created_at": "2018-03-28T17:55:43Z",
    "updated_at": "2018-03-28T17:55:43Z",
    "service_templates": [
        {
            "href": "http://localhost:3000/api/service_templates/33",
            "id": "33",
            "name": "my migration plan",
            "description": "test (optional)",
            "guid": "96cb504b-eaf2-4dc1-b3f6-64ae85bbcbc8",
            "type": "ServiceTemplateTransformationPlan",
            "service_template_id": null,
            "options": {
                "config_info": {
                    "transformation_mapping_id": "1",
                    "vm_ids": [
                        "1",
                        "3"
                    ]
                }
            },
            "created_at": "2018-02-22T21:46:48Z",
            "updated_at": "2018-02-22T21:46:48Z",
            "display": false,
            "evm_owner_id": null,
            "miq_group_id": "2",
            "service_type": "atomic",
            "prov_type": "generic",
            "provision_cost": null,
            "service_template_catalog_id": null,
            "long_description": null,
            "tenant_id": "1",
            "generic_subtype": "custom"
        },
        {
            "href": "http://localhost:3000/api/service_templates/34",
            "id": "34",
            "name": "migration plan 2",
            "description": "test 2",
            "guid": null,
            "type": "ServiceTemplateTransformationPlan",
            "service_template_id": null,
            "options": {},
            "created_at": "2018-04-11T14:25:24Z",
            "updated_at": "2018-04-11T14:25:24Z",
            "display": null,
            "evm_owner_id": null,
            "miq_group_id": null,
            "service_type": null,
            "prov_type": null,
            "provision_cost": null,
            "service_template_catalog_id": null,
            "long_description": null,
            "tenant_id": null,
            "generic_subtype": null
        }
    ]
}

bdunne · 2018-04-10T13:42:49Z

app/models/transformation_mapping.rb

@@ -3,7 +3,13 @@ class TransformationMapping < ApplicationRecord

  validates :name, :presence => true, :uniqueness => true

+  virtual_has_many :service_templates


Can this be a regular has_many :through to avoid the collect?
cc @kbrock

yea. remove this line

kbrock

thanks for the ping brandon - yes, I think a regular association works better here

kbrock · 2018-04-10T16:08:52Z

app/models/transformation_mapping.rb

@@ -3,7 +3,13 @@ class TransformationMapping < ApplicationRecord

  validates :name, :presence => true, :uniqueness => true

+  virtual_has_many :service_templates


yea. remove this line

kbrock · 2018-04-10T16:16:02Z

app/models/transformation_mapping.rb

  def destination(source)
    transformation_mapping_items.find_by(:source => source).try(:destination)
  end
+
+  def service_templates


has_many :service_resources
has_many :service_templates, :through => :service_resources

kbrock · 2018-04-10T16:18:40Z

spec/models/transformation_mapping_spec.rb

@@ -18,4 +18,13 @@
      expect(mapping.destination(FactoryGirl.create(:ems_cluster))).to be_nil
    end
  end
+
+  describe '#service_templates' do


specs look good - this will be able to test if the real relation works as well as the virtual one

miq-bot · 2018-04-11T13:31:53Z

Checked commit lfu@71f732c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/models/transformation_mapping.rb

❗ - Line 3, Col 3 - Rails/InverseOf - Specify an :inverse_of option.

kbrock · 2018-04-11T20:55:16Z

Yay. looking good lucy

Add association of service_templates to TransformationMapping. (cherry picked from commit 802d601)

simaishi · 2018-05-29T19:10:43Z

Gaprindashvili backport details:

$ git log -1
commit e93c2c651732cc237433db2f459d9af84310ccd1
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Apr 11 11:33:39 2018 -0400

    Merge pull request #17266 from lfu/mapping_has_many_plans
    
    Add association of service_templates to TransformationMapping.
    (cherry picked from commit 802d601b1356d1e861ed4f6064e9043f33630e76)

miq-bot assigned gmcculloug Apr 9, 2018

miq-bot added enhancement v2v labels Apr 9, 2018

bzwei reviewed Apr 9, 2018

View reviewed changes

lfu force-pushed the mapping_has_many_plans branch from 2c33e10 to b4d8280 Compare April 9, 2018 21:38

lfu changed the title ~~Add method TransformationMapping#service_template_transformation_plans.~~ Add method TransformationMapping#service_templates. Apr 9, 2018

bzwei reviewed Apr 10, 2018

View reviewed changes

lfu force-pushed the mapping_has_many_plans branch from b4d8280 to f6178b3 Compare April 10, 2018 13:34

bdunne reviewed Apr 10, 2018

View reviewed changes

kbrock reviewed Apr 10, 2018

View reviewed changes

lfu force-pushed the mapping_has_many_plans branch from f6178b3 to 15758bc Compare April 10, 2018 18:15

lfu changed the title ~~Add method TransformationMapping#service_templates.~~ Add association of service_templates to TransformationMapping. Apr 10, 2018

lfu force-pushed the mapping_has_many_plans branch from 15758bc to 082c288 Compare April 10, 2018 18:54

Add association of service_templates to TransformationMapping.

71f732c

lfu force-pushed the mapping_has_many_plans branch from 082c288 to 71f732c Compare April 11, 2018 13:27

bzwei approved these changes Apr 11, 2018

View reviewed changes

gmcculloug merged commit 802d601 into ManageIQ:master Apr 11, 2018

gmcculloug added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 11, 2018

lfu deleted the mapping_has_many_plans branch April 27, 2018 19:58

gmcculloug added the gaprindashvili/yes label May 17, 2018

simaishi pushed a commit that referenced this pull request May 29, 2018

Merge pull request #17266 from lfu/mapping_has_many_plans

e93c2c6

Add association of service_templates to TransformationMapping. (cherry picked from commit 802d601)

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels May 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add association of service_templates to TransformationMapping. #17266

Add association of service_templates to TransformationMapping. #17266

lfu commented Apr 9, 2018

bzwei Apr 9, 2018

bzwei commented Apr 9, 2018

bzwei Apr 10, 2018

lfu commented Apr 10, 2018

bdunne Apr 10, 2018

kbrock Apr 10, 2018

kbrock left a comment

kbrock Apr 10, 2018

kbrock Apr 10, 2018

kbrock Apr 10, 2018

miq-bot commented Apr 11, 2018

kbrock commented Apr 11, 2018

simaishi commented May 29, 2018

		@@ -3,7 +3,13 @@ class TransformationMapping < ApplicationRecord

		validates :name, :presence => true, :uniqueness => true

		virtual_has_many :service_template_transformation_plans

		@@ -3,7 +3,13 @@ class TransformationMapping < ApplicationRecord

		validates :name, :presence => true, :uniqueness => true

		virtual_has_many :service_templates

Add association of service_templates to TransformationMapping. #17266

Add association of service_templates to TransformationMapping. #17266

Conversation

lfu commented Apr 9, 2018

bzwei Apr 9, 2018

Choose a reason for hiding this comment

bzwei commented Apr 9, 2018

bzwei Apr 10, 2018

Choose a reason for hiding this comment

lfu commented Apr 10, 2018

bdunne Apr 10, 2018

Choose a reason for hiding this comment

kbrock Apr 10, 2018

Choose a reason for hiding this comment

kbrock left a comment

Choose a reason for hiding this comment

kbrock Apr 10, 2018

Choose a reason for hiding this comment

kbrock Apr 10, 2018

Choose a reason for hiding this comment

kbrock Apr 10, 2018

Choose a reason for hiding this comment

miq-bot commented Apr 11, 2018

kbrock commented Apr 11, 2018

simaishi commented May 29, 2018