Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :transformation under product and set it to true by default #17270

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Add :transformation under product and set it to true by default #17270

merged 1 commit into from
Apr 11, 2018

Conversation

AparnaKarve
Copy link
Contributor

Add the :transformation flag under the product section and set it to true by default.

This flag enables/disables v2v UI.

Related UI PR - https://github.com/priley86/miq_v2v_ui_plugin/pull/190

@AparnaKarve
Copy link
Contributor Author

@gmcculloug Added the transformation flag in settings.yml like we discussed.
Please review. Thanks.

@miq-bot
Copy link
Member

miq-bot commented Apr 9, 2018

Checked commit AparnaKarve@f0a5f24 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@AparnaKarve AparnaKarve changed the title Add :transformation under product and set to true by default Add :transformation under product and set it to true by default Apr 9, 2018
@gmcculloug gmcculloug self-assigned this Apr 10, 2018
@gmcculloug gmcculloug requested a review from Fryguy April 10, 2018 11:34
@AparnaKarve
Copy link
Contributor Author

https://github.com/priley86/miq_v2v_ui_plugin/pull/190 has been merged -- which means, without this PR v2v UI would not be visible by default.

@Fryguy Fryguy merged commit 9eecc2a into ManageIQ:master Apr 11, 2018
@Fryguy Fryguy added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 11, 2018
@gmcculloug
Copy link
Member

@simaishi I think this should be back-ported to the Gaprindashvili branch but with the flag switched to false

@AparnaKarve AparnaKarve deleted the add_transformation_flag_to_settings branch April 11, 2018 13:58
@simaishi
Copy link
Contributor

@gmcculloug In that case... I think it'll be better to create a separate PR, as it will be confusing if the commit does the opposite of what PR says!

@gmcculloug
Copy link
Member

Or change the title and description to be less informative. 😆 But I would agree that it is better as a separate PR.

@AparnaKarve
Copy link
Contributor Author

Alright, I will create a separate PR for Gaprindashvili - not a problem :)

@AparnaKarve AparnaKarve mentioned this pull request Apr 11, 2018
Merged
@AparnaKarve
Copy link
Contributor Author

@simaishi Gaprindashvili PR - #17285

@JPrause
Copy link
Member

JPrause commented May 2, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label May 2, 2018
@AparnaKarve AparnaKarve mentioned this pull request Jul 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy

Assignees

@gmcculloug gmcculloug

Labels
enhancement v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AparnaKarve @miq-bot @gmcculloug @simaishi @JPrause @Fryguy