Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get allocated values of sub metrics for cloud volumes in chargeback without rollups #17277

Merged

Conversation

lpichler
Copy link
Contributor

We didn't consider sub_metric of cloud volume when we are getting allocated values for chargeback without rollups.
These metric values are getting in ConsumptionWithoutRollups#current_value

Links

@miq-bot assign @gtanzillo
@miq-bot add_label bug, chargeback

@lpichler
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

@lpichler lpichler changed the title Get allocated values of sub metrics for cloud volumes in chargeback without rollups [WIP] Get allocated values of sub metrics for cloud volumes in chargeback without rollups Apr 12, 2018
@miq-bot miq-bot added the wip label Apr 12, 2018
Fix is for chargeback without rollups where is used only method
current_value to get allocations.
@lpichler lpichler force-pushed the get_allocatted_values_also_for_metrics branch 3 times, most recently from 8a84568 to 1e672b3 Compare April 13, 2018 16:28
@lpichler lpichler changed the title [WIP] Get allocated values of sub metrics for cloud volumes in chargeback without rollups Get allocated values of sub metrics for cloud volumes in chargeback without rollups Apr 15, 2018
@miq-bot miq-bot removed the wip label Apr 15, 2018
@lpichler lpichler force-pushed the get_allocatted_values_also_for_metrics branch from 1e672b3 to 4c985a4 Compare April 15, 2018 20:58
@miq-bot
Copy link
Member

miq-bot commented Apr 15, 2018

Checked commits lpichler/manageiq@c83e145~...4c985a4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo merged commit 4c02603 into ManageIQ:master Apr 24, 2018
simaishi pushed a commit that referenced this pull request May 14, 2018
…r_metrics

Get allocated values of sub metrics for cloud volumes in chargeback without rollups
(cherry picked from commit 4c02603)

https://bugzilla.redhat.com/show_bug.cgi?id=1578124
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 53a3e9e242385315b33929a9f003bc2ea09af20a
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue Apr 24 09:21:20 2018 -0400

    Merge pull request #17277 from lpichler/get_allocatted_values_also_for_metrics
    
    Get allocated values of sub metrics for cloud volumes in chargeback without rollups
    (cherry picked from commit 4c026037760866e1f2ba9fe03ee5fbc0e402fe2e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1578124

@lpichler lpichler deleted the get_allocatted_values_also_for_metrics branch May 15, 2018 06:07
@agrare agrare added this to the Sprint 85 Ending May 7, 2018 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants