-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get allocated values of sub metrics for cloud volumes in chargeback without rollups #17277
Merged
gtanzillo
merged 3 commits into
ManageIQ:master
from
lpichler:get_allocatted_values_also_for_metrics
Apr 24, 2018
Merged
Get allocated values of sub metrics for cloud volumes in chargeback without rollups #17277
gtanzillo
merged 3 commits into
ManageIQ:master
from
lpichler:get_allocatted_values_also_for_metrics
Apr 24, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miq-bot add_label gaprindashvili/yes |
lpichler
changed the title
Get allocated values of sub metrics for cloud volumes in chargeback without rollups
[WIP] Get allocated values of sub metrics for cloud volumes in chargeback without rollups
Apr 12, 2018
Fix is for chargeback without rollups where is used only method current_value to get allocations.
lpichler
force-pushed
the
get_allocatted_values_also_for_metrics
branch
3 times, most recently
from
April 13, 2018 16:28
8a84568
to
1e672b3
Compare
lpichler
changed the title
[WIP] Get allocated values of sub metrics for cloud volumes in chargeback without rollups
Get allocated values of sub metrics for cloud volumes in chargeback without rollups
Apr 15, 2018
lpichler
force-pushed
the
get_allocatted_values_also_for_metrics
branch
from
April 15, 2018 20:58
1e672b3
to
4c985a4
Compare
Checked commits lpichler/manageiq@c83e145~...4c985a4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Apr 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
simaishi
pushed a commit
that referenced
this pull request
May 14, 2018
…r_metrics Get allocated values of sub metrics for cloud volumes in chargeback without rollups (cherry picked from commit 4c02603) https://bugzilla.redhat.com/show_bug.cgi?id=1578124
Gaprindashvili backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't consider sub_metric of cloud volume when we are getting allocated values for chargeback without rollups.
These metric values are getting in ConsumptionWithoutRollups#current_value
Links
@miq-bot assign @gtanzillo
@miq-bot add_label bug, chargeback