Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .yamllint config to provider generators #17281

Merged

Conversation

imtayadeway
Copy link
Contributor

Provides a config so the yaml linter can be run on the provider repos.

I've made the default line length rather long (1000) to account for vcr cassettes which tend to extend hundreds of characters in width - we can look into tuning this or alternatively ignoring cassettes (since they are generated).

@agrare
Copy link
Member

agrare commented Apr 10, 2018

@imtayadeway ran a quick wc -L on some provider VCRs and some of them are >70,000 chars wide so might be better to ignore spec/vcr_cassettes/**

@djberg96
Copy link
Contributor

Agree with @agrare. Ok for other yaml spec files, but lets ignore cassettes for now.

@imtayadeway imtayadeway force-pushed the add-yamllint-to-provider-generator branch from 754a761 to 6adcf97 Compare April 10, 2018 20:28
@imtayadeway
Copy link
Contributor Author

@agrare @djberg96 thanks for the recommendations! I added the cassettes path to the ignore list, and reduced the line length to 120 which I think is in line with the other linters.

@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2018

Checked commit imtayadeway@6adcf97 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@djberg96
Copy link
Contributor

👍

@Fryguy Fryguy merged commit 9b6635b into ManageIQ:master Apr 10, 2018
@Fryguy Fryguy added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants