Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINE] Adds purging for notifications #17294

Merged
merged 1 commit into from
Apr 16, 2018
Merged

[FINE] Adds purging for notifications #17294

merged 1 commit into from
Apr 16, 2018

Conversation

NickLaMuro
Copy link
Member

@NickLaMuro NickLaMuro commented Apr 12, 2018 •
edited by simaishi
Loading

  • Sets notifications that are older than a week to be purged by default.
  • Purging is run daily
  • Clears out notification recipients as well

Links

@NickLaMuro NickLaMuro mentioned this pull request Apr 12, 2018
Merged
@NickLaMuro
Copy link
Member Author

Oops... guess a couple of files didn't get included here... fixing...

@NickLaMuro
Adds purging for notifications
03e335c 
* Sets notifications that are older than a week to be purged by default.
* Purging is run daily
* Clears out notification recipients as well
@miq-bot
Copy link
Member

miq-bot commented Apr 16, 2018

Checked commit NickLaMuro@03e335c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@simaishi simaishi requested a review from jrafanie April 16, 2018 15:09
@simaishi simaishi self-assigned this Apr 16, 2018
jrafanie
jrafanie approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a Fine PR. 👍

@simaishi simaishi merged commit 27101aa into ManageIQ:fine Apr 16, 2018
@simaishi simaishi added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@simaishi simaishi

Labels
core performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickLaMuro @miq-bot @jrafanie @simaishi