Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method retire_now to container OrchestrationStack. #17298

Merged

Conversation

lfu
Copy link
Member

@lfu lfu commented Apr 13, 2018

So the container service may be retired.

https://bugzilla.redhat.com/show_bug.cgi?id=1564154

@miq-bot assign @gmcculloug
@miq-bot add_label bug, gaprindashvili/yes

cc @bzwei

@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2018

Checked commit lfu@1eb5531 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@gmcculloug gmcculloug merged commit 05e85b1 into ManageIQ:master Apr 13, 2018
@gmcculloug gmcculloug added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 13, 2018
@lfu lfu deleted the service_container_retirement_1564154 branch April 27, 2018 19:58
simaishi pushed a commit that referenced this pull request May 15, 2018
Add method retire_now to container OrchestrationStack.
(cherry picked from commit 05e85b1)

https://bugzilla.redhat.com/show_bug.cgi?id=1578398
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d460eb81e3d3c9701c78a4d37810a0e7025d05d0
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Apr 13 11:37:31 2018 -0400

    Merge pull request #17298 from lfu/service_container_retirement_1564154
    
    Add method retire_now to container OrchestrationStack.
    (cherry picked from commit 05e85b1f34fb1007cf2bc6de77844a8c62c1a749)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1578398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants