Add call for bundled service children retirement #17317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label retirement |
d-m-u
changed the title
d-m-u
changed the title
d-m-u
changed the title
d-m-u
changed the title
d-m-u
force-pushed
the
adding_bundled_service_child_retire_thingies
branch
from
8bda8ad
to
047a5b5
Compare
d-m-u
changed the title
|
@tinaafitz can you please 👀 |
|
Checked commit d-m-u@047a5b5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
bump @mkanoor @gmcculloug |
|
bump @mkanoor 👻 |
mkanoor
reviewed
May 7, 2018
| parent_service.service_resources.collect do |svc_rsc| | ||
| next unless svc_rsc.resource.present? && svc_rsc.resource.respond_to?(:retire_now) | ||
| next if svc_rsc.resource.type.blank? |
There was a problem hiding this comment.
@d-m-u
Can we validate that this code gets executed. According to @tinaafitz a child service would get marked as an blank resource type.
There was a problem hiding this comment.
The top level service itself has a blank type and we're not creating task for it to retire in this method so we need this check. The child services do have types, they're type Vm or Service or Whatever.
mkanoor
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All direct service children of the parent service in a bundled service need to go through the create_retire_subtasks method so that child vms get retired as well.
WIP'd cause requires automate changes.