Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] Azure labels and tags mapping support #17321

Conversation

AlexanderZagaynov
Copy link
Contributor

@AlexanderZagaynov AlexanderZagaynov commented Apr 20, 2018

@AlexanderZagaynov AlexanderZagaynov changed the title [GAPRINDASHVILI] azure labels and tags mapping support [GAPRINDASHVILI] Azure labels and tags mapping support Apr 20, 2018
@AlexanderZagaynov
Copy link
Contributor Author

@simaishi @Ladas @bronaghs please review

@simaishi
Copy link
Contributor

@AlexanderZagaynov Is this different from #17212? A separate PR is needed, only if the 'master' PR can't be cherry-picked.

@AlexanderZagaynov
Copy link
Contributor Author

@simaishi this is a simple cherry-pick from master

@simaishi
Copy link
Contributor

Then, this PR isn't needed... You'll need to create a separate PR for different branches only when the 'master' PR can't be cherry-picked.

@miq-bot
Copy link
Member

miq-bot commented Apr 20, 2018

Checked commit AlexanderZagaynov@b4961a3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@AlexanderZagaynov
Copy link
Contributor Author

closing in favour of direct cherry-picking by @simaishi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants