Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of defined analyisis profile missed in vm scanning. #17331

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

hsong-rh
Copy link
Contributor

Normally job state transition is done by signal to the next state, which will save job options. But here the MiqQueue is used to change job states, the profiles information has to be saved before proceeding.

https://bugzilla.redhat.com/show_bug.cgi?id=1553808

@miq-bot
Copy link
Member

miq-bot commented Apr 23, 2018

Checked commit hsong-rh@4b43b96 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@hsong-rh
Copy link
Contributor Author

@roliveri @jerryk55 Please review

@jerryk55
Copy link
Member

Looks good to me!

@bdunne bdunne merged commit 792f495 into ManageIQ:master Apr 30, 2018
@bdunne bdunne added this to the Sprint 85 Ending May 7, 2018 milestone Apr 30, 2018
@bdunne bdunne self-assigned this Apr 30, 2018
simaishi pushed a commit that referenced this pull request May 14, 2018
Fix the issue of defined analyisis profile missed in vm scanning.
(cherry picked from commit 792f495)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578121
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 7ca3a3086135373e9e9d5562353817083c7fbe3a
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Mon Apr 30 16:19:12 2018 -0400

    Merge pull request #17331 from hsong-rh/scanning_profile
    
    Fix the issue of defined analyisis profile missed in vm scanning.
    (cherry picked from commit 792f495c208c4bfd07eb7da2654e294159a6ad95)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants