Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change current_group for super admin user when executing Rbac#lookup_user_group #17347

Merged
merged 3 commits into from
May 1, 2018
Merged

Do not change current_group for super admin user when executing Rbac#lookup_user_group #17347

merged 3 commits into from
May 1, 2018

Commits on Apr 26, 2018

  1. do not change current_group for super admin user when executing Rbac#… 

    …lookup_user_group

Example when updating user.current_group in group's look-up is bad: if widget set-up for different group than during content generation (triggered manually from UI) the last group will become current group for super user and this may throw unexpectd errors ( like failing ApplicationController.assert_privileges(widget_refresh)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1564986
    @yrudman
    yrudman committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    d7a37e8 View commit details
    Browse the repository at this point in the history

  2. added rspec to check that use.currentuser is not updated if user is s… 

    …uperadmin
    @yrudman
    yrudman committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    911af7e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. litle bit of DRY

    @yrudman
    yrudman committed May 1, 2018
    Configuration menu
    Copy the full SHA
    c798fc5 View commit details
    Browse the repository at this point in the history