-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memoize _log.prefix calls #17355
Merged
bdunne
merged 1 commit into
ManageIQ:master
from
NickLaMuro:memoize_log_prefix_calls_in_miq_request_workflow
Apr 27, 2018
Merged
Memoize _log.prefix calls #17355
bdunne
merged 1 commit into
ManageIQ:master
from
NickLaMuro:memoize_log_prefix_calls_in_miq_request_workflow
Apr 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a relatively expensive method for how many times it is called, and the cases in which is being used, it doesn't change it's value ever between subsequent calls. This simply memoizes the value that is generated, which very much decreases the amount of duplicate work that is done for these methods.
Checked commit NickLaMuro@c982f6c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Apr 27, 2018
Merged
@miq-bot assign @gmcculloug |
This was referenced May 3, 2018
simaishi
pushed a commit
that referenced
this pull request
Jun 21, 2018
…_miq_request_workflow Memoize _log.prefix calls (cherry picked from commit c2e01c9) https://bugzilla.redhat.com/show_bug.cgi?id=1593798
Fine backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Jun 21, 2018
…_miq_request_workflow Memoize _log.prefix calls (cherry picked from commit c2e01c9) https://bugzilla.redhat.com/show_bug.cgi?id=1593797
Gaprindashvili backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where an EMS has a large number of hosts, the tree that gets built is quite large, and so the number of times that
_log.prefix
is fired is very high. This updates each one of those calls to memoize them to a instance variable, since the resulting prefix will not change.Benchmarks
The benchmark script used here basically runs the following:
And is targeting a fairly large EMS, with about 600 hosts.
Note: The benchmarks for this change do NOT include the changes from other PRs (#17354 for example). Benchmarks of all changes can be found here.
Links