Change dialog import to only use auto_refresh if new triggers are blank #17363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eclarizio can you 👀 for me please? |
|
@miq-bot add_label bug |
eclarizio
suggested changes
Apr 27, 2018
| association_list = (associations_to_be_created + old_associations).reject(&:blank?) | ||
| build_associations(new_or_existing_dialog, association_list) | ||
| association_list = new_associations.reject(&:blank?).present? ? new_associations : build_old_association_list(new_or_existing_dialog.dialog_fields).flatten | ||
| binding.pry |
There was a problem hiding this comment.
You might not want this here anymore :)
d-m-u
force-pushed
the
change_import_field_responders_to_not_use_old_if_new_exist_on_dialog
branch
2 times, most recently
from
72a8755
to
9e1af4d
Compare
…e nonexistent. If using a new dialog, the DialogFieldAssociations should be what we're using
d-m-u
force-pushed
the
change_import_field_responders_to_not_use_old_if_new_exist_on_dialog
branch
from
9e1af4d
to
b1650e5
Compare
|
Checked commit d-m-u@b1650e5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
deleted the
change_import_field_responders_to_not_use_old_if_new_exist_on_dialog
branch
simaishi
pushed a commit
that referenced
this pull request
Apr 30, 2018
…o_not_use_old_if_new_exist_on_dialog Change dialog import to only use auto_refresh if new triggers are blank (cherry picked from commit f8e4a47) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1573254
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old field associations still exist and are used to create the dialog associations on import. Because you can't touch the auto_refresh in the UI anymore but they still live in db and exist when we export dialogs. So if we have new associations we should use them and only them, not both the old associations and the new ones.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1572777