Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dequeued shutdown_and_exit messages from MiqQueue on server start #17370

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented May 1, 2018

@miq-bot
Copy link
Member

miq-bot commented May 1, 2018

@yrudman unrecognized command 'add', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@yrudman yrudman closed this May 2, 2018
@yrudman yrudman reopened this May 2, 2018
@yrudman yrudman force-pushed the delete-shutdown-message-crom-queue-on-server-start branch from 3fc7ffc to cb8f107 Compare May 2, 2018 22:08
@miq-bot
Copy link
Member

miq-bot commented May 2, 2018

Checked commits yrudman/manageiq@87cbb0c~...cb8f107 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/models/miq_server/at_startup.rb

@yrudman
Copy link
Contributor Author

yrudman commented May 2, 2018

@jrafanie could you review this

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie self-assigned this May 3, 2018
@jrafanie jrafanie merged commit 2aba99c into ManageIQ:master May 3, 2018
@jrafanie jrafanie added this to the Sprint 85 Ending May 7, 2018 milestone May 3, 2018
@yrudman yrudman deleted the delete-shutdown-message-crom-queue-on-server-start branch May 3, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants