Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up Redfish inventory collector #17393

Merged
merged 1 commit into from
May 25, 2018
Merged

Wire up Redfish inventory collector #17393

merged 1 commit into from
May 25, 2018

Conversation

tadeboro
Copy link
Contributor

@tadeboro tadeboro commented May 8, 2018

Commits in this pull request add collection for physical servers and register refresh worker that will handle refresh requests.

/cc @gberginc @gtanzillo @Fryguy

@gberginc
Copy link
Contributor

gberginc commented May 9, 2018

Marking WIP as it depends on the provider actually being migrated to ManageIQ.

@miq-bot add_label wip

@miq-bot miq-bot changed the title Wire up Redfish inventory collector [WIP] Wire up Redfish inventory collector May 9, 2018
@miq-bot miq-bot added the wip label May 9, 2018
@tadeboro tadeboro force-pushed the redfish-inventory-collector branch from 2f8d5df to eb0ec68 Compare May 15, 2018 20:15
@tadeboro
Copy link
Contributor Author

@miq-bot remove_label wip

@tadeboro
Copy link
Contributor Author

Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id=1574808

@miq-bot miq-bot changed the title [WIP] Wire up Redfish inventory collector Wire up Redfish inventory collector May 15, 2018
@miq-bot miq-bot removed the wip label May 15, 2018
@gberginc
Copy link
Contributor

Are the two changes independent? If they are, I suggest you create two PRs.

@tadeboro tadeboro force-pushed the redfish-inventory-collector branch from eb0ec68 to de86563 Compare May 16, 2018 08:30
@tadeboro
Copy link
Contributor Author

@gberginc Changes in commits are related, but not dependent, so I split the pull request into two parts. This pull request now on simply registers refresh worker that will handle inventory update jobs.

Pull request #17392 must be merged before this pull request, because it references classes, defined in Redfish provider.

@gberginc
Copy link
Contributor

@miq-bot add_label wip

Apart from the dependency on another PR, this looks fine!

@miq-bot miq-bot changed the title Wire up Redfish inventory collector [WIP] Wire up Redfish inventory collector May 16, 2018
@miq-bot miq-bot added the wip label May 16, 2018
@tadeboro tadeboro force-pushed the redfish-inventory-collector branch from de86563 to d3a964a Compare May 18, 2018 07:40
@miq-bot
Copy link
Member

miq-bot commented May 18, 2018

Checked commit xlab-si@d3a964a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@tadeboro
Copy link
Contributor Author

Pull request #17392 has been merged and all requirements for this pull request are now met.

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Wire up Redfish inventory collector Wire up Redfish inventory collector May 18, 2018
@miq-bot miq-bot removed the wip label May 18, 2018
@tadeboro
Copy link
Contributor Author

@miq-bot assign @gtanzillo

@martinpovolny
Copy link
Member

ping @Ladas, @lpichler

Ladas
Ladas approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

agrare
agrare approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare assigned agrare and unassigned gtanzillo May 25, 2018
@agrare agrare merged commit ee36b9d into ManageIQ:master May 25, 2018
@agrare agrare added this to the Sprint 87 Ending Jun 4, 2018 milestone May 25, 2018
@tadeboro tadeboro deleted the redfish-inventory-collector branch May 28, 2018 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
enhancement providers/physical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tadeboro @gberginc @miq-bot @martinpovolny @Ladas @agrare @gtanzillo