Nested lazy find with secondary ref #17425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if reference contains only references to primary indexes inside
Assert we build InventoryObject only with references to primary index
…ill fail Test that secondary reference, used for InventoryObject manager ref will fail
Transform nested references with secondary index on load
Test nested references with secondary index work
Add guard for nested references being too deep
Make nested lazy finds explicit for now, before we are able to transform it automatically, when needed.
Test explicit transform_nested_lazy_finds
1 task
|
Checked commits Ladas/manageiq@b5f8585~...d1405c2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manager_refresh/inventory_object_lazy.rb
spec/models/manager_refresh/persister/finders_spec.rb
|
agrare
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested lazy find with secondary ref. Allowing to pass option, that will transform all nested InventoryObjectLazy into InventoryObject, allowing us to use nested InventoryObjectLazy with secondary references