Added export/import of SmartState Analysis Profiles #17427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gtanzillo |
juliancheal
changed the title
juliancheal
force-pushed
the
export_analysis_profiles
branch
from
0c54268
to
a210fad
Compare
|
@jerryk55 Hey Jerry, does this like correct to you? Is there anything you would expect in a Scan Profile, export / import. |
|
@juliancheal looks good except for the error handling on the exception during the import - commented out puts right now. The actual import/export from/to yaml seems fine. |
|
@jerryk55 Thanks :) |
juliancheal
force-pushed
the
export_analysis_profiles
branch
from
a210fad
to
a0c6379
Compare
juliancheal
changed the title
juliancheal
force-pushed
the
export_analysis_profiles
branch
3 times, most recently
from
ab4105c
to
667c212
Compare
Fixes BZ #1344589
juliancheal
force-pushed
the
export_analysis_profiles
branch
from
667c212
to
207fcaa
Compare
|
Checked commit juliancheal@207fcaa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/task_helpers/imports/scan_profiles.rb
|
|
@gtanzillo merge? We're all 🍏🛶🥝🌱 |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1344589