Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use feature for admin #17444

Merged
merged 5 commits into from
May 31, 2018
Merged

Use feature for admin #17444

merged 5 commits into from
May 31, 2018

Commits on May 29, 2018

  1. use :role instead of :name for role specs

    @kbrock
    kbrock committed May 29, 2018
    Configuration menu
    Copy the full SHA
    9c9a52f View commit details
    Browse the repository at this point in the history

  2. move disallowed_roles calculation to rbac

    @kbrock
    kbrock committed May 29, 2018
    Configuration menu
    Copy the full SHA
    83ad831 View commit details
    Browse the repository at this point in the history

  3. User#with_current_user_groups -> with_groups 

    move hardcoded admin logic over to rbac
    @kbrock
    kbrock committed May 29, 2018
    Configuration menu
    Copy the full SHA
    fd13a8a View commit details
    Browse the repository at this point in the history

  4. use features to check if a role is an admin role 

    the role name used to determine if it were

https://bugzilla.redhat.com/show_bug.cgi?id=1090627
    @kbrock
    kbrock committed May 29, 2018
    Configuration menu
    Copy the full SHA
    db76d96 View commit details
    Browse the repository at this point in the history

  5. separate report and request admins 

    Admins have 2 types of escalated privileges
report and request

This separates the types (with 2 different product features)
    @kbrock
    kbrock committed May 29, 2018
    Configuration menu
    Copy the full SHA
    f6c02e8 View commit details
    Browse the repository at this point in the history