Do not delete children snapshots as part of parent #17462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not delete children snapshots as part of parent. The default relation :children, added by acts_as_tree, has :dependent => :destroy. So deleting parent, will delete all it's children. This is not behavior we want in refresh. In old refresh, we were bypassing this by: https://github.com/ManageIQ/manageiq/blob/master/app/models/ems_refresh/save_inventory.rb#L366 So first, we deleted the tree relations, then we did create/update/delete of the nodes, then we updated the tree connections again. All of that should not be needed, if we will just use :dependent => :nullify Partially fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1571291
|
Checked commit Ladas@ff840c9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@Ladas I was thinking about this after we talked and I think the problem here is that it will leave orphaned child snaps if you destroy the vm. |
|
@Ladas pointed out in gitter that we already dependent destroy snapshots related to a VM so the tree delete is redundant. |
simaishi
pushed a commit
that referenced
this pull request
May 22, 2018
…with_parent Do not delete children snapshots as part of parent (cherry picked from commit 2903440) https://bugzilla.redhat.com/show_bug.cgi?id=1581287
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not delete children snapshots as part of parent. The default
relation :children, added by acts_as_tree, has :dependent => :destroy.
So deleting parent, will delete all it's children. This is not behavior
we want in refresh. In old refresh, we were bypassing this by:
https://github.com/ManageIQ/manageiq/blob/master/app/models/ems_refresh/save_inventory.rb#L366
So first, we deleted the tree relations, then we did create/update/delete
of the nodes, then we updated the tree connections again. All of that should
not be needed, if we will just use :dependent => :nullify
Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1571291
PR with spec is here:
ManageIQ/manageiq-providers-ovirt#241