Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changes to enable workers to be started in containers #17493

Merged
merged 1 commit into from
May 31, 2018

Conversation

carbonin
Copy link
Member

This will allow us to use the G-release architecture for the
H-release container images without undoing all of the work
in #15884

https://www.pivotaltracker.com/story/show/157774394

These changes really only need to be here for the hammer branch.

Merging them to master will break manageiq-pods master branch, but if we want to branch hammer in manageiq-pods then we really need this here now.

Interested in what people think about a way to proceed with this.

This will allow us to use the G-release architecture for the
H-release container images without undoing all of the work
in ManageIQ#15884

https://www.pivotaltracker.com/story/show/157774394
@miq-bot
Copy link
Member

miq-bot commented May 29, 2018

Checked commit carbonin@8467e94 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin changed the title [WIP] Remove changes to enable workers to be started in containers Remove changes to enable workers to be started in containers May 30, 2018
@miq-bot miq-bot removed the wip label May 30, 2018
@bdunne bdunne merged commit f42f3fa into ManageIQ:master May 31, 2018
@bdunne bdunne added this to the Sprint 87 Ending Jun 4, 2018 milestone May 31, 2018
@carbonin carbonin deleted the un_rearch_containers branch August 16, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants