Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the profile description option to the provision error message #17495

Merged
merged 1 commit into from
May 30, 2018
Merged

Adding the profile description option to the provision error message #17495

merged 1 commit into from
May 30, 2018

Conversation

AlonaKaplan
Copy link
Contributor

If the requested vlan/network is wrong, the error message will be-
'Virtual NIC Profile ID or Profile Name (Network Name)'

Fixes https://bugzilla.redhat.com/1578393
Fixes https://bugzilla.redhat.com/1574351

@AlonaKaplan
Adding the profile description option to the provision error message
159e360 
If the requested vlan/network is wrong, the error message will be-
'Virtual NIC Profile ID or Profile Name (Network Name)'

Fixes https://bugzilla.redhat.com/1578393
Fixes https://bugzilla.redhat.com/1574351
@AlonaKaplan
Copy link
Contributor Author

@agrare, @pkliczewski please review

@AlonaKaplan
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes, bug

@miq-bot
Copy link
Member

miq-bot commented May 30, 2018

Checked commit AlonaKaplan@159e360 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit f277495 into ManageIQ:master May 30, 2018
@agrare agrare added this to the Sprint 87 Ending Jun 4, 2018 milestone May 30, 2018
@agrare agrare self-assigned this May 30, 2018
simaishi pushed a commit that referenced this pull request May 30, 2018
@agrare @simaishi
Merge pull request #17495 from AlonaKaplan/required_description
fdd5b2e 
Adding the profile description option to the provision error message
(cherry picked from commit f277495)

https://bugzilla.redhat.com/show_bug.cgi?id=1578393
https://bugzilla.redhat.com/show_bug.cgi?id=1584406
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit fdd5b2e568e52042ccb233cff19b0dd08b3e5482
Author: Adam Grare <agrare@redhat.com>
Date:   Wed May 30 11:49:19 2018 -0400

    Merge pull request #17495 from AlonaKaplan/required_description
    
    Adding the profile description option to the provision error message
    (cherry picked from commit f27749569895ad0249877debf246bdfa2b5134c3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1578393
    https://bugzilla.redhat.com/show_bug.cgi?id=1584406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@pkliczewski pkliczewski pkliczewski approved these changes

Assignees

@agrare agrare

Labels
bug gaprindashvili/backported lifecycle/provisioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlonaKaplan @miq-bot @simaishi @pkliczewski @agrare