Join object and block storage under ems_storage in the features tree

[skateman]

I'm trying to refactor something in the UI. For that I would like to have a way to determine if a feature related to a given model is available for a user. However, there are some inconsistencies between the features and models of storage providers.

There are three feature subtrees for storage providers:

• ems_storage
• ems_object_storage
• ems_block_storage

When displaying a list of storage manager, the system is using the ems_{block,object}_storage route and I'm assuming also the feature with the same name from the RBAC tree. However, when opening a provider's summary screen, the route changes to ems_storage. This, together with the lack of separate object/block storage provider model classes is causing a lot of struggle with decorators/quadicons.

To solve this problem, we had this idea with @PanSpagetka to join the two specific features under the generic one. This would solve us the problem of sub-features when deciding if we want to expose the quadicon settings to a given user for the storage providers.

I was clicking in the UI a little and it seems working, also tested our case by creating a user with access only to ems_object_storage_view:

Rbac.role_allows?(:user => u, :feature => :ems_storage, :any => true) # => true
Rbac.role_allows?(:user => u, :feature => :ems_block_storage, :any => true) # => true
Rbac.role_allows?(:user => u, :feature => :ems_block_storage_view, :any => true) # => true
Rbac.role_allows?(:user => u, :feature => :ems_object_storage, :any => true) # => false
Rbac.role_allows?(:user => u, :feature => :ems_object_storage_view, :any => true) # => false

However, I think this is too good to be true and I am afraid I don't see the whole picture and/or I'm breaking something 😕

[miq-bot]

Checked commit skateman@3b671a1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

[kbrock]

Change makes sense

Don't think this will effect anything other than a change in the product feature tree in settings config