Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Archive/Unarchive for Service Templates to features #17518

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Add Archive/Unarchive for Service Templates to features #17518

merged 1 commit into from
Jun 5, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Jun 4, 2018

Add the archive and unarchive actions on service_templates to product
features.

Related: ManageIQ/manageiq-api#389

@agrare
Add (Un)/Archive for Service Templates to features
c82a7fe 
Add the archive and unarchive actions on service_templates to product
features.
@miq-bot
Copy link
Member

miq-bot commented Jun 4, 2018

Checked commit agrare@c82a7fe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare mentioned this pull request Jun 4, 2018
Merged
@michaelkro michaelkro mentioned this pull request Jun 5, 2018
Merged
@agrare
Copy link
Member Author

agrare commented Jun 5, 2018

@abellotti can you review?

@abellotti abellotti assigned h-kataria and unassigned abellotti Jun 5, 2018
@abellotti
Copy link
Member

LGTM!! Thanks @agrare, but I yield to @h-kataria for final approval as she knows better than I.

@agrare
Copy link
Member Author

agrare commented Jun 5, 2018

@h-kataria can you PTAL?

@h-kataria
Copy link
Contributor

@abellotti LGTM

@h-kataria h-kataria requested review from h-kataria and removed request for h-kataria June 5, 2018 19:31
@h-kataria h-kataria added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 5, 2018
@h-kataria h-kataria merged commit 7b85ecd into ManageIQ:master Jun 5, 2018
@agrare agrare deleted the add_archive_unarchive_product_features branch June 5, 2018 19:33
@AparnaKarve
Copy link
Contributor

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1593890

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Jun 21, 2018
@h-kataria @simaishi
Merge pull request #17518 from agrare/add_archive_unarchive_product_f…
23e26a2 
…eatures

Add Archive/Unarchive for Service Templates to features
(cherry picked from commit 7b85ecd)

https://bugzilla.redhat.com/show_bug.cgi?id=1594023
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 23e26a2205e5f55edfa9548630768bdd69201c7b
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Jun 5 15:32:39 2018 -0400

    Merge pull request #17518 from agrare/add_archive_unarchive_product_features
    
    Add Archive/Unarchive for Service Templates to features
    (cherry picked from commit 7b85ecd997adba3174c6cea744460de59956c083)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1594023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
blocker enhancement gaprindashvili/backported lifecycle/provisioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agrare @miq-bot @abellotti @h-kataria @AparnaKarve @simaishi