move #my_zone from ArchivedMixin to OldEmsMixin

[bzwei]

Not every model that needs ArchivedMixin has ext_management_system or #old_ext_management_sytem. For those do need to use #old_ext_management_system now they should include OldEmsMixin.

This is a followup PR of #17480
Fixes issue #17535

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1594873

Gap backport: #17540

[bzwei]

@miq-bot assign @agrare
@miq-bot label bug

[miq-bot]

@bzwei unrecognized command 'label', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

[miq-bot]

Checked commit bzwei@8e753a1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 1 offense detected

app/models/mixins/old_ems_mixin.rb

• ❗ - Line 5, Col 5 - Rails/InverseOf - Specify an :inverse_of option.

[agrare]

Looks good to me, let me run the kubernetes and openshift specs with this applied to master and I'll merge if that's green

[bzwei]

@miq-bot add_label Gaprindashvili/yes

[agrare]

Kubernetes and Openshift specs pass

[agrare]

BZ https://bugzilla.redhat.com/show_bug.cgi?id=1594873
/cc @simaishi

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 17a3e84538a452304556990478627e1d080c7e7b
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Jun 6 15:45:12 2018 -0400

    Merge pull request #17539 from bzwei/old_ems_id
    
    move #my_zone from ArchivedMixin to OldEmsMixin
    (cherry picked from commit 8bd16646c6efd64a808731f50d99eef12bc53962)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1595418

[Fryguy]

Just saw this now, but this is a really weird place for this method. I get that OldEmsMixin should enhance the method, but it feels more correct for there to be a method in the base class that does my_zone normally, and this method can do what it does followed by calling super. @agrare ?

[agrare]

@Fryguy yeah I see what you mean, there doesn't seem to be a whole lot that the base model's my_zone method does though, they all look like:

  def my_zone
    ems = ext_management_system
    ems ? ems.my_zone : MiqServer.my_zone
  end

So we would have to refactor them all to allow this to get in the middle before falling back to MiqServer.my_zone.
Maybe a method my_ems which my_zone would call then this mixin could enhance the my_ems method?