Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the virtual columns to be able to use in the API with filter[] #17553

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Jun 7, 2018

Primary use case is to be able to use filter[]=archived=true in the API, which was not possible before due to the ? in the virtual column name.

Also added the active attribute/virtual column

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1593890

@AparnaKarve
Copy link
Contributor Author

@agrare Please review.

@miq-bot
Copy link
Member

miq-bot commented Jun 7, 2018

Checked commit AparnaKarve@fa60b22 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 2 offenses detected

app/models/mixins/archived_mixin.rb

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

@AparnaKarve
Copy link
Contributor Author

AparnaKarve commented Jun 19, 2018

@agrare Can you review/merge this?

We will need this change for gaprindashvili since we cannot directly query the deleted_on attribute in the API for gaprindashvili

@agrare agrare self-assigned this Jun 20, 2018
@agrare
Copy link
Member

agrare commented Jun 20, 2018

hey @AparnaKarve sorry I missed this because it wasn't assigned to me

@agrare agrare merged commit 58af1d2 into ManageIQ:master Jun 20, 2018
@agrare agrare added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 20, 2018
@AparnaKarve AparnaKarve deleted the fix_archived_api_attribute branch June 20, 2018 13:59
@AparnaKarve
Copy link
Contributor Author

@agrare Thank you!

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Jun 21, 2018
Fixed the virtual columns to be able to use in the API with `filter[]`
(cherry picked from commit 58af1d2)

https://bugzilla.redhat.com/show_bug.cgi?id=1594023
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 518a0ae326e8d78c1a1c61e1ff037a0ab961975b
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Jun 20 08:56:40 2018 +0200

    Merge pull request #17553 from AparnaKarve/fix_archived_api_attribute
    
    Fixed the virtual columns to be able to use in the API with `filter[]`
    (cherry picked from commit 58af1d2d7be4b6974accb8a47031c7aef3fc3591)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1594023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants