Add physical infra related default collections #17557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
reviewed
Jun 11, 2018
| :model_class => ::Hardware, | ||
| :association => :hardwares, | ||
| :manager_ref => [:computer_system], | ||
| :parent_inventory_collections => [:computer_systems], |
There was a problem hiding this comment.
the parent should be the top level entity, so :parent_inventory_collections => [:physical_servers]
(saying that, it should be probably named root_inventory_collections)
you would see this fail when doing targeted refresh, where it would build invalid SQL (I think I should be able to add assert that parent_inventory_collections must not have parents)
Newly added collections are used by physical infra providers when performing inventory refresh.
tadeboro
force-pushed
the
add-physical-infra-default-collections
branch
from
e7c409a
to
6455b1c
Compare
|
Checked commit xlab-si@6455b1c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly added collections are used by physical infra providers when
performing inventory refresh.
@miq-bot assign @gtanzillo
/cc @gberginc @matejart