Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user_timezone method for MiqReportResult public #17569

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 12, 2018

We need this method in the UI for the new printing/PDF exports.

https://bugzilla.redhat.com/show_bug.cgi?id=1588072
Related issue: ManageIQ/manageiq-ui-classic#4113

@miq-bot add_label gaprindashvili/no, reporting
@miq-bot add_reviewer @lpichler

Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lpichler
Copy link
Contributor

@miq-bot assign @bdunne

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2018

Checked commit skateman@6542037 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@bdunne bdunne merged commit ac2377a into ManageIQ:master Jun 12, 2018
@bdunne bdunne added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 12, 2018
@skateman skateman deleted the timezone-public branch June 12, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants