Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject empty button groups from the result of #custom_actions #17607

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

skateman
Copy link
Member

When a button group has only buttons that are hidden by an expression, the empty button group still gets returned by the API and displayed in the SUI. My added reject call drops all button groups from the result of #custom_actions that have been evaluated as hidden.

@miq-bot assign @gtanzillo

https://bugzilla.redhat.com/show_bug.cgi?id=1590764

@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2018

Checked commit skateman@739171c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 3 offenses detected

app/models/mixins/custom_actions_mixin.rb

spec/models/mixins/custom_actions_mixin_spec.rb

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gtanzillo gtanzillo added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 20, 2018
@gtanzillo gtanzillo merged commit 362b5ff into ManageIQ:master Jun 20, 2018
@skateman skateman deleted the hide-button-groups branch June 20, 2018 13:39
@JPrause
Copy link
Member

JPrause commented Sep 19, 2018

@miq-bot add_label blocker

@JPrause
Copy link
Member

JPrause commented Sep 19, 2018

@skateman if this can be backported, can you add the gaprindashvili/yes label

@skateman
Copy link
Member Author

@miq-bot add_label gaprindashvili/yes

@simaishi
Copy link
Contributor

simaishi commented Oct 3, 2018

This was pushed to cfme-5.10, removing gaprindashvili/yes flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants