Fix ordering of metric rollups in consumption history #17620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized: sporadic failure/test |
the issue is that we got improper count of hours of Consumption#consumed_hours_in_interval it was caused that set of metric rollups (after pluck) is not ordered according to timestamp. Then we could not get proper first metric rollup according to timestamp and then we were badly calculating consumed_hours_in_interval here.
lpichler
force-pushed
the
fix_ordering_metric_rollups_in_consumption_history
branch
from
463cc96
to
85da8cd
Compare
|
Checked commit lpichler@85da8cd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label blocker |
|
As per BZ Target Release, removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is fixing sporadic failures caused by #17592
the issue is that we got improper count of hours of
Consumption#consumed_hours_in_intervalit was caused that set of metric rollups (after pluck) is not ordered according to timestamp.
Then we could not get proper first metric rollup according to timestamp and then we were badly calculating
consumed_hours_in_intervalhere.Links
https://travis-ci.org/ManageIQ/manageiq/jobs/393976777
https://bugzilla.redhat.com/show_bug.cgi?id=1601590
@miq-bot assign @gtanzillo
@miq-bot add_label gaprindashvili/yes, sporadic failure/test