Adding title and cve's to openscap_rule_result creation #17651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianwatsonrh 👍 |
|
Checked commit ianwatsonrh@6017b2c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
roliveri
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request for #17219 (comment) with a rebase.
In conjunction with PR OpenSCAP/ruby-openscap#12
Gives the ability to store OpenSCAP Rule title and linked CVE's. This gives usefulness to the OpenSCAP reporting options in cloudforms. Currently only only a non human friendly id is present and there are no links to the actual CVE references.
This change also requires a schema change to the database:
class AddCVEToOpenScapRuleResults < ActiveRecord::Migration[5.0] def change add_column :openscap_rule_results, :title, :string add_column :openscap_rule_results, :cves, :string end end
@hsong-rh please review.