Miq server zone description #17662
Merged
Miq server zone description #17662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a virtual column delegated to a belongs_to class Classic example of virtual_delegate
If the server name is nil, then code sometimes blows up This defines the description on miq server so it acts like most of our other models displayed in the ui
|
Checked commits kbrock/manageiq@421074d~...545e771 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most ui objects have a description. MiqServer does not. The ui server list (used by alert profiles view) blows up when fetching a server without a name.
MiqServer#zone_description is a typical virtual delegate. a virtual column that is delegated to another model
This is not a BZ bug, but it makes the screen blow up. so I've marked it as a bug