-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate name uniqueness for Transformation Plans #17677
Validate name uniqueness for Transformation Plans #17677
Conversation
@bzwei do you know why it is failing to have the validation on the subclass? This works from a rails console but fails on the spec test, granted I was calling just |
@agrare our factories for service_template models are all nameless because the base class does not have uniqueness requirement. You will need to feed one name for |
Add a unique name validation, scoped to the tenant, for ServiceTemplateTransformationPlans. ManageIQ/manageiq-v2v#451
dda7260
to
fb695d0
Compare
@bzwei oh actually I wasn't even talking about those spec failures, this morning when I tried adding a spec test it passed and didn't raise an exception. PTAL |
Checked commit agrare@fb695d0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Thanks @bzwei |
…rmation_plan Validate name uniqueness for Transformation Plans (cherry picked from commit 6586413) https://bugzilla.redhat.com/show_bug.cgi?id=1608768
Gaprindashvili backport details:
|
Add a unique name validation, scoped to the tenant, for
ServiceTemplateTransformationPlans.
ManageIQ/manageiq-v2v#451
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1567225