Assign userid to key_pairs while creating

[andyvesel]

Added user_id to create_key_pair and create_key_pair_queue methods in order to create keypairs with assigned user ids to them.
This needed for further fixes in https://bugzilla.redhat.com/show_bug.cgi?id=1589766

[aufi]

@miq-bot add_label bug,blocker

[Ladas]

@andyvesel you have some unrelated commits in this PR, can you rebase?

[miq-bot]

Checked commit andyvesel@e84934f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[aufi]

LGTM 👍

[andyvesel]

@Ladas could you review?

[Ladas]

Looks acceptable 👍

[Ladas]

@miq-bot assign @agrare

[agrare]

The Authentications.userid field isn't intended to be used for this, it is the string username in a username/password pair.

What I think you want is to add an actual user_id foreign key and add a belongs_to :user to authentications/key_pairs and probably use the existing OwnershipMixin and/or TennancyMixin
/cc @gtanzillo @Fryguy

[JPrause]

@andyvesel if this can be backported, please add the gaprindashvili/yes label

[agrare]

@andyvesel @aufi this should be able to be replaced by #17731

[agrare]

#17731 was merged, closing