Add rake task to export custom buttons

[d-m-u]

We need to be able to import/export custom buttons. This is basically a generic active record object export that works on custom buttons.

The related import PR:
#17726

Related:

#17726

Exporting

Create a directory for the exports:
mkdir /tmp/custom_buttons
Export cbs:
rake evm:export:custom_buttons -- --directory /tmp/custom_buttons

The export has a list of custom_button_sets with nested custom_buttons and associated resource actions as well as custom_buttons without sets and their associated resources.

export looks like this:

[d-m-u]

@miq-bot add_label enhancement

[d-m-u]

@tinaafitz @syncrou @eclarizio
@whoever_wants_to_review_me

[d-m-u]

@miq-bot remove_label wip

[syncrou]

@d-m-u - some small nits, but would like to see specs around this.

[syncrou]

@d-m-u Should we have some validation that this directory exists?

[d-m-u]

The export helper itself handles that here: https://github.com/ManageIQ/manageiq/blob/master/lib/task_helpers/exports.rb#L22

[syncrou]

@d-m-u - Building the associations are in the weeds, but I wouldn't mind seeing variable names that reflect what the variable is e.g. r, d

[miq-bot]

Checked commit d-m-u@e6f816f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

[syncrou]

LGTM 👍

[gmcculloug]

@d-m-u Looks good. My only comment is around exporting the userid for custom_button. It makes sense to include it here for when import/export is used as a backup solution. My concern is what to do during import into a new system when that userid does not exist.

At the moment this ID is only used for tracking who created the button. I'll comment on the import PR so we can address this.

[borisko123]

Hi, it seems I've found the problem in https://github.com/ManageIQ/manageiq/blob/master/spec/lib/task_helpers/imports/custom_buttons_spec.rb
Namely, the certain example is passed, but not for good reason.
The example at line 28 is about raising error, when we have 'bad file' in directory
It is passed, but this is not due to right flow, but due to error in
https://github.com/ManageIQ/manageiq/blob/master/lib/task_helpers/imports/custom_buttons.rb
The glob on line 6 is about *.yaml, BUT rspec generates temp 'bad' file with extension yamlXXXXX
where XXXX is some random thing.
So the glob does not include this file and the actually repeats " context "with existing identical buttons""

It seems the glob should be like *.yaml* in order to test this case
Also, line 33 should be deleted.

Also, we should explicitly remove tmp file in the example code, otherwize the whole test may fail
randomly.
Something like:
file = Tempfile.new('foo') begin ...do something with file... ensure file.close file.unlink # deletes the temp file end
Am I right?

[gmcculloug]

Hi @borisko123, thanks for reporting this issue. Can you please open a git issue and someone can take a look. Thanks.

[borisko123]

Hi @borisko123, thanks for reporting this issue. Can you please open a git issue and someone can take a look. Thanks.

Hi @gmcculloug,
Among others things at PR #20137(add dialog support, ability to update existing buttons), I also fixed this issue.The solution was to use another Tempfile initializer, which enables to retain file extension.
The glob is untouched.
Please take a look