Allow for empty strings in the execution_ttl field #17715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1601538 An empty string yields a 0 timeout value causing jobs to be terminated right away.
|
Checked commit mkanoor@40abd08 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bzwei @gmcculloug @Fryguy Please review |
bzwei
approved these changes
Jul 16, 2018
gmcculloug
modified the milestones:
Sprint 90 Ending Jul 16, 2018,
Sprint 91 Ending Jul 30, 2018
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
Allow for empty strings in the execution_ttl field (cherry picked from commit 2c27c3c) https://bugzilla.redhat.com/show_bug.cgi?id=1608368
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1601538
An empty string yields a 0 timeout value causing jobs to be
terminated right away.
Use default timeout value if the execution_ttl is nil or an empty string