Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InventoryCollection definitions for vmware infra #17729

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Jul 19, 2018

Issue: #17396

dependent: ManageIQ/manageiq-providers-vmware#299

InventoryCollection Builder extension for vmware infra - new IC definitions

Also fix for merging default values and dependency attributes (previously these values defined by add_properties were ignored)

@slemrmartin
Copy link
Contributor Author

Cc @agrare

@slemrmartin slemrmartin mentioned this pull request Jul 19, 2018
33 tasks
Also fix for merging IC properties
@miq-bot
Copy link
Member

miq-bot commented Jul 19, 2018

Checked commit slemrmartin@46c83c7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare merged commit 46c83c7 into ManageIQ:master Jul 19, 2018
agrare added a commit that referenced this pull request Jul 19, 2018
InventoryCollection definitions for vmware infra
@agrare agrare added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants