[RFE] Allow customizing product title and brand image through settings #17773
Conversation
|
\cc @dclarizio |
skateman
changed the title
| :name => I18n.t("product.name"), | ||
| :description => "#{I18n.t("product.name")} Default Organization" | ||
| :name => Vmdb::Appliance.PRODUCT_NAME, | ||
| :description => "#{Vmdb::Appliance.PRODUCT_NAME} Default Organization" |
There was a problem hiding this comment.
This looks like a missing i18n not getting any better with this PR
ping @mzazrivec
There was a problem hiding this comment.
I think this part of the backend code creates objects in the embedded ansible instance and I'd say there's no point in applying i18n here.
There was a problem hiding this comment.
@carbonin Can you just review this particular file just in case?
config/settings.yml
Outdated
| @@ -974,6 +974,7 @@ | |||
| :keep_archived_quotas: 6.months | |||
| :purge_window_size: 1000 | |||
| :product: | |||
| :name: null | |||
There was a problem hiding this comment.
Where will we put "Red Hat CloudForms" if this is the approach? Right now we create a config/settings/production.yml that is layered on settings.yml, but I think it's layered after settings.yml. If the user wants to "remove" that value, where do you think they will enter this value?
|
Checked commits skateman/manageiq@a08c049~...2d3b069 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -1001,6 +1002,8 @@ | |||
| :console_proxy_port: | |||
| :start: 6000 | |||
| :end: 7000 | |||
| :custom_brand: false | |||
| :custom_login_logo: false | |||
There was a problem hiding this comment.
I notice this is added to the :server key as opposed to :product. Are we expecting a different custom brand per server?
There was a problem hiding this comment.
What will these be used for? I don't see them elsewhere in the PR.
There was a problem hiding this comment.
This is already being used and missing, I added this for the sake of consistency.
There was a problem hiding this comment.
I was not really thinking about the location, added the missing and the needed key to the same place where the existing custom_logo was.
|
@miq-bot add_label fine/yes, gaprindashvili/yes |
The product name is stored in a YAML file that is not very convenient to edit. There's a "constant" around the
i18n.tcall that retrieves the name, however it was not used globally. So first I replaced all thei18n.tcalls with the constant and then added an option to retrieve the product name fromSettings.product.namethat is editable through the advanced settings in OPS UI. Also added the missingcustom_login_logoand the newcustom_brandkeys to the settings.@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @martinpovolny
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1471301