Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pt_BR.yml for Brazilian Portuguese #17775

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Add pt_BR.yml for Brazilian Portuguese #17775

merged 1 commit into from
Jul 30, 2018

Conversation

mzazrivec
Copy link
Contributor

One effect of the change is correctly rendered browser title in Brazilian Portuguese.

Before:
title-before

After:
title-after

https://bugzilla.redhat.com/show_bug.cgi?id=1609810

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Jul 30, 2018

Checked commit mzazrivec@1a6996d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec
Copy link
Contributor Author

@miq-bot add_label blocker, internationalization

@h-kataria
Copy link
Contributor

Looks good

@h-kataria h-kataria added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 30, 2018
@h-kataria h-kataria merged commit 5b11e28 into ManageIQ:master Jul 30, 2018
@mzazrivec mzazrivec deleted the add_yml_for_brazilian_portuguese branch July 30, 2018 15:22
simaishi pushed a commit that referenced this pull request Aug 6, 2018
@h-kataria @simaishi
Merge pull request #17775 from mzazrivec/add_yml_for_brazilian_portug…
f4d96d2 
…uese

Add pt_BR.yml for Brazilian Portuguese
(cherry picked from commit 5b11e28)

https://bugzilla.redhat.com/show_bug.cgi?id=1612856
@simaishi
Copy link
Contributor

simaishi commented Aug 6, 2018

Gaprindashvili backport details:

$ git log -1
commit f4d96d25ba241e2b633be62220f5cd35d03eb6b3
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Jul 30 11:20:35 2018 -0400

    Merge pull request #17775 from mzazrivec/add_yml_for_brazilian_portuguese
    
    Add pt_BR.yml for Brazilian Portuguese
    (cherry picked from commit 5b11e28294a66759604493fb05d638a44ad9a305)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1612856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
blocker gaprindashvili/backported internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzazrivec @miq-bot @h-kataria @simaishi @martinpovolny