-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Remove Selected Items from Inventory button for Images, Instances #17780
Fix Remove Selected Items from Inventory button for Images, Instances #17780
Conversation
@miq-bot add_label bug, blocker, gaprindashvili/yes |
43b7615
to
30b2549
Compare
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1601955 Fix the button by adding support for destroy to VmOrTemplate model.
30b2549
to
7de8cf2
Compare
Checked commit hstastna@7de8cf2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@Ladas What do you think about that? Thank you ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@agrare the story here is the the "Remove from VMDB" button never had any check, but UI guys are consolidating the buttons code, so now every action needs to have |
👍 good find, I wonder how many other buttons are like this though 😱 |
…ance Fix Remove Selected Items from Inventory button for Images, Instances
As per BZ Target Release, removing |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1601955
There is a problem with 'Remove selected items from Inventory' button in all the pages under Compute > Clouds while trying to remove Instance or Image. It's because
validate_destroy
method is called every time we try to delete some item but this method is available only for Host, at least for now.Steps to reproduce: (one of possible scenarios)
=> the selected Images/Instances are not removed, error:
Before:
After: