Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'require_nested :ConfigurationWorkflow' from parent space #17782

Merged
merged 1 commit into from
Jul 31, 2018
Merged

remove 'require_nested :ConfigurationWorkflow' from parent space #17782

merged 1 commit into from
Jul 31, 2018

Conversation

jameswnl
Copy link
Contributor

Followup to #17720

@agrare agrare self-assigned this Jul 31, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2018

Checked commit jameswnl@4f076d3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

agrare
agrare approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM should follow up with some specs

@agrare agrare merged commit 765f565 into ManageIQ:master Jul 31, 2018
@agrare agrare added this to the Sprint 92 Ending Aug 13, 2018 milestone Jul 31, 2018
@jameswnl jameswnl deleted the workflow4 branch July 31, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug providers/automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameswnl @miq-bot @agrare @Fryguy