New and improved Field.is_field?() #17801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue when MiqExpression engine is a regular expression and the field looks like "Model-field" but the attribute doesn't exist Example: if there is vm named "Lan-yuri" than this expression Virtual Machine : Name REGULAR EXPRESSION MATCHES "L+" triggers error https://bugzilla.redhat.com/show_bug.cgi?id=1581853
kbrock
force-pushed
the
check-if-valid-field
branch
from
ae4765d
to
4dc6d18
Compare
|
Checked commit kbrock@4dc6d18 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
reviewed
Aug 5, 2018
| begin | ||
| parsed_params[:model_name] = parsed_params[:model_name].classify.safe_constantize | ||
| rescue LoadError # issues for case sensitivity (e.g.: VM vs vm) | ||
| parsed_params[:model_name] = nil |
There was a problem hiding this comment.
I thought safe_constantize's purpose is to never raise a LoadError, but to return nil instead. How would the LoadError path ever occur?
There was a problem hiding this comment.
"Vm".safe_constantize # good
nil.safe_constantize # good
"XYZ".safe_constantize # good
"VM".safe_constantize
LoadError: Unable to autoload constant VM, expected app/models/vm.rb to define it
There was a problem hiding this comment.
@Fryguy "Vm" fails for me all the time, but having trouble reproducing this for a rails PR.
safe_constantize does not catch LoadError - so it makes some sense.
This may be an auto_load path issue
|
👍 It looks good, there is no need to introduce new method in #17760 |
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
New and improved Field.is_field?() (cherry picked from commit ec091b9) https://bugzilla.redhat.com/show_bug.cgi?id=1615465
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yrudman and I had discussed this and I wanted to capture my local code before I lost it.
This is an alternate to #17760
Fixes issue when MiqExpression engine is a regular expression
and the field looks like "Model-field" but the attribute doesn't exist
Example: if there is vm named "Lan-yuri" than this expression
Virtual Machine : Name REGULAR EXPRESSION MATCHES "L+" triggers error
https://bugzilla.redhat.com/show_bug.cgi?id=1581853