Don't queue metrics capture if metrics unsupported #17820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
bz_1610449_dont_queue_capture_targets_if_ems_doesnt_support_metrics
branch
from
3667f73
to
26c52c1
Compare
agrare
force-pushed
the
bz_1610449_dont_queue_capture_targets_if_ems_doesnt_support_metrics
branch
from
26c52c1
to
377d868
Compare
agrare
commented
Aug 8, 2018
app/models/ext_management_system.rb
Outdated
| @@ -292,6 +292,10 @@ def supports_authentication?(authtype) | |||
| authtype.to_s == "default" | |||
| end | |||
|
|
|||
| def supports_metrics? | |||
There was a problem hiding this comment.
TODO this should be a supports_feature_mixin but kubernetes already has this method defined here
|
I applied the PR to 5.9.0.22 (appliance) and it corrected the problem. This looks like a clean and quick fix. I'm chuffed to bits over how elegant that fix is, with just a single line. Thanks for the PR, Adam. |
agrare
changed the title
If metrics capture is unsupported by the provider then do not queue perf_capture for targets on that EMS. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610449
agrare
force-pushed
the
bz_1610449_dont_queue_capture_targets_if_ems_doesnt_support_metrics
branch
from
377d868
to
d78c076
Compare
|
Checked commit agrare@d78c076 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
deleted the
bz_1610449_dont_queue_capture_targets_if_ems_doesnt_support_metrics
branch
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
…argets_if_ems_doesnt_support_metrics Don't queue metrics capture if metrics unsupported (cherry picked from commit 6439a45) https://bugzilla.redhat.com/show_bug.cgi?id=1618805
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If metrics capture is unsupported by the provider then do not queue
perf_capture for targets on that EMS.
https://bugzilla.redhat.com/show_bug.cgi?id=1610449