Don't log the deprecation debug messages in production #17824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit bdunne@df146c8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Aug 9, 2018
jrafanie
reviewed
Aug 10, 2018
| @@ -30,7 +30,7 @@ def self.proc_for_default_log | |||
| return unless default_log | |||
| proc do |message, callstack| | |||
| default_log.warn(message) | |||
| default_log.debug(callstack.join("\n ")) if default_log.debug? | |||
There was a problem hiding this comment.
WAT. We were calling debug on the logger after first checking if it was debug? We were trying to avoid the unnecessary string allocations in the case of info log level? I vaguely recall you can pass a block to accomplish the same thing.
There was a problem hiding this comment.
in other words...
default_log.debug { callstack.join("\n ") }
Or something like that... either way, I like the change... in dev and test mode, we don't care about the allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1609905
Deprecation warning debug messages aren't so helpful in production and add a lot more noise to the logs.