rake evm:db:restore:remote mods for S3 #17827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
Aug 10, 2018
lib/tasks/evm_dba.rake
Outdated
| @@ -172,6 +172,7 @@ namespace :evm do | |||
| opt :uri, "Destination depot URI", :type => :string, :required => true | |||
| opt :uri_username, "Destination depot username", :type => :string | |||
| opt :uri_password, "Destination depot password", :type => :string | |||
| opt :uri_region, "Destination depot region", :type => :string | |||
There was a problem hiding this comment.
I don't think the AWS region has anything to do with the URI, right? Can this option be called aws_region instead?
lib/tasks/evm_dba.rake
Outdated
| @@ -271,6 +273,7 @@ namespace :evm do | |||
| opt :uri, "Destination depot URI", :type => :string, :required => true | |||
| opt :uri_username, "Destination depot username", :type => :string | |||
| opt :uri_password, "Destination depot password", :type => :string | |||
| opt :uri_region, "Destination depot region", :type => :string | |||
There was a problem hiding this comment.
Same here, would prefer if this could be aws_region
When rake evm:db:restore:remote is issued with an S3 URI, specify the AWS region as an argument to be passed to EvmDatabaseOps
Since the region option has nothing to do with the URI, but is AWS specific, rename the option appropriately, per review comments.
jerryk55
force-pushed
the
rake_s3_db_restore_mods
branch
from
b395a37
to
348b1bd
Compare
|
Checked commits jerryk55/manageiq@cf65236~...348b1bd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/tasks/evm_dba.rake
|
carbonin
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rake evm:db:restore:remote is issued with an S3 URI,
specify the AWS region as an argument to be passed to EvmDatabaseOps
As part of several PRs required for the RFE described in https://bugzilla.redhat.com/show_bug.cgi?id=1513520, this will change the rake process invoked from appliance_console when the DB is
restored from S3. Another PR for appliance_console is to be added and noted herein.
@carbonin, @NickLaMuro, @roliveri please review and merge when appropriate. Thanks.
Links
Steps for Testing/QA
After backing up a DB to S3, use appliance_console to restore the DB. Use option 4 to request a restore, and option 4 again to restore from S3. Enter the valid URI, userid, password, and region.