human_attribute_name(): add ui option to be able to call original (super) method #17834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to reflect the original function prototype.
|
Checked commits mzazrivec/manageiq@a28204b~...b4fc632 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
human_attribute_name()prototype, instead of*argswe should useoptions = {}to match the prototype of original parent functionoptions[:ui]parameter for us to be able to call the original, i.e.supermethod.human_attribute_name()is used in UI to automatically construct labels in textual summaries. With the change that I'm suggesting we're gonna be back to labels likeNameinstead ofManageIQ::Providers::Openstack::CloudManager::CloudVolume Name.See #17754 for the original motivation to override
human_attribute_name().