Remove admin_user? method #17850
Merged
Remove admin_user? method #17850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kbrock
force-pushed
the
admin_user_no_more
branch
2 times, most recently
from
3b1b161
to
aacfecc
Compare
|
This pull request is not mergeable. Please rebase and repush. |
In ManageIQ#17444 and related PRs References to generic admin_user and used request_admin_user/others This removes the method for good
The role of "administrator" specially set product features This has been removed. So we are focusing on features and not some magic "administrator" role
kbrock
force-pushed
the
admin_user_no_more
branch
from
aacfecc
to
a72fce8
Compare
|
Checked commits kbrock/manageiq@e94374b~...a72fce8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda related to #17849
In #17444 (and related PRs) We transitioned generic references of
admin_user?to more specialized functionality likerequest_admin_user?All references to
admin_user?were removed. This removes the method ✂️✂️✂️