-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Audit logging to new user creation #17852
Added Audit logging to new user creation #17852
Conversation
ae35dab
to
c6b0fa2
Compare
c6b0fa2
to
2012beb
Compare
6ee74fa
to
f2b3215
Compare
@jvlcek @Fryguy I've got the tests passing for example
|
@juliancheal The tests were updated to include mixed case to ensure the auth code correctly handles mixed case. I'm not sure why your tests need the userid in mixed case but I'd be glad to pair up and try to figure it you, if you'd like. |
@jvlcek let's meet after standup. |
👍 LGTM |
Userid was being stored in audit event, before being downcased. Changing the order of those two lines now makes the tests make more sense.
cffe5f5
to
53f2be3
Compare
Checked commits juliancheal/manageiq@2012beb~...53f2be3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@gtanzillo @Fryguy We ok to merge? |
@miq-bot add_label gaprindashvili/yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Follow up to PR ManageIQ#17852 Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1602136
Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1602136
Raises an audit event when new external logins are auto-created for the first time.
Creates the following audit message:
User creation successful for User: Bob Builderson with ID: bob