Add new rename_queue method to VM operations #17853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agrare @h-kataria This is the method we need for the new feature - adding ability to rename VMs :) |
agrare
reviewed
Aug 13, 2018
| @@ -75,6 +75,24 @@ def rename(new_name) | |||
| raw_rename(new_name) | |||
| end | |||
|
|
|||
| def rename_queue(userid, new_name) | |||
| task_opts = { | |||
| :action => "Renanimg VM for user #{userid}", | |||
There was a problem hiding this comment.
Just pushed a commit to fix the typo
agrare
approved these changes
Aug 13, 2018
|
Checked commits hstastna/manageiq@9bc9d3c~...29c1af1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
added a commit
that referenced
this pull request
Aug 13, 2018
Add new rename_queue method to VM operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1559184
UI PR: ManageIQ/manageiq-ui-classic#4351
This PR adds a new
rename_queuemethod needed for the UI to get a propertask_idwhile renaming a VM (only VMWare).