Ensure options is always a hash #17917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
approved these changes
Aug 28, 2018
d-m-u
approved these changes
Aug 28, 2018
eclarizio
approved these changes
Aug 28, 2018
ManageIQ#17802 added a line that called [] on options and if nil, it would raise NoMethodError where it should have returned nil
bdunne
force-pushed
the
fix_the_api_specs_after_17802
branch
from
fcad896
to
41fb53c
Compare
|
Checked commit bdunne@41fb53c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Sep 13, 2018
Ensure options is always a hash (cherry picked from commit 64f9089) https://bugzilla.redhat.com/show_bug.cgi?id=1618800
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17802 added a line that called
[]on options and if nil, it would raise NoMethodError where it should have returned nilhttps://github.com/ManageIQ/manageiq/pull/17802/files#diff-72d768ae2e73b9e77080d4a7df59cf56R226
Thanks for the debugging help @d-m-u !